gatorsmile commented on a change in pull request #24774: [SPARK-27899][SQL]
Make HiveMetastoreClient.getTableObjectsByName available in
ExternalCatalog/SessionCatalog API
URL: https://github.com/apache/spark/pull/24774#discussion_r291035734
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
##########
@@ -277,6 +277,20 @@ abstract class ExternalCatalogSuite extends SparkFunSuite
with BeforeAndAfterEac
}
}
+ test("get tables by name") {
+ assert(newBasicCatalog().getTablesByName("db2", Seq("tbl1", "tbl2"))
+ .map(_.identifier.table) == Seq("tbl1", "tbl2"))
+ }
+
+ test("get tables by name when some tables do not exists") {
+ assert(newBasicCatalog().getTablesByName("db2", Seq("tbl1", "tblnotexist"))
Review comment:
See `validNameFormat`. Add a test case when the seq of table names contains
the invalid name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
