mengxr commented on a change in pull request #24643:
[SPARK-26412][PySpark][SQL][WIP] Allow Pandas UDF to take an iterator of
pd.Series or an iterator of tuple of pd.Series
URL: https://github.com/apache/spark/pull/24643#discussion_r291398385
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
##########
@@ -175,16 +183,20 @@ object ExtractPythonUDFs extends Rule[LogicalPlan] with
PredicateHelper {
AttributeReference(s"pythonUDF$i", u.dataType)()
}
- val evaluation = validUdfs.partition(
- _.evalType == PythonEvalType.SQL_SCALAR_PANDAS_UDF
- ) match {
- case (vectorizedUdfs, plainUdfs) if plainUdfs.isEmpty =>
- ArrowEvalPython(vectorizedUdfs, resultAttrs, child)
- case (vectorizedUdfs, plainUdfs) if vectorizedUdfs.isEmpty =>
- BatchEvalPython(plainUdfs, resultAttrs, child)
- case _ =>
+ val evalType = validUdfs.head.evalType
Review comment:
~~~scala
val evalTypes = validUdfs.map(_.evalType).toSet
if (evalTypes.size != 1) {
// .. include `evalTypes` in the error message
}
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
