mengxr commented on a change in pull request #24643:
[SPARK-26412][PySpark][SQL][WIP] Allow Pandas UDF to take an iterator of
pd.Series or an iterator of tuple of pd.Series
URL: https://github.com/apache/spark/pull/24643#discussion_r291397901
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
##########
@@ -111,19 +111,27 @@ object ExtractPythonUDFs extends Rule[LogicalPlan] with
PredicateHelper {
}
private def collectEvaluableUDFsFromExpressions(expressions:
Seq[Expression]): Seq[PythonUDF] = {
- // Eval type checker is set once when we find the first evaluable UDF and
its value
- // shouldn't change later.
- // Used to check if subsequent UDFs are of the same type as the first UDF.
(since we can only
+ // If fisrt UDF is SQL_SCALAR_PANDAS_ITER_UDF, then only return this UDF,
+ // otherwise check if subsequent UDFs are of the same type as the first
UDF. (since we can only
// extract UDFs of the same eval type)
- var evalTypeChecker: Option[EvalTypeChecker] = None
+
+ var firstVisitedUDFEvalType: Option[Int] = None
+
+ def checkEvalType(evalType: Int): Boolean = {
Review comment:
rename it to `canChainUDF`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
