srowen commented on a change in pull request #24702: [SPARK-27989] [Kubernetes]
[Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r292001320
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -283,7 +283,12 @@ private[spark] object CoarseGrainedExecutorBackend
extends Logging {
executorConf,
new SecurityManager(executorConf),
clientMode = true)
- val driver = fetcher.setupEndpointRefByURI(arguments.driverUrl)
+
+ val driver = retry(3) {
+ fetcher.setupEndpointRefByURI(arguments.driverUrl)
+ }
Review comment:
I think this can still just be simpler.
```
var driver: RpcEndpointRef = null
for (i <- 0 until 3) {
try {
driver = ...
} catch {
case e: Throwable => // continue
}
}
require(driver != null, "...")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
