rdblue commented on a change in pull request #24832: [SPARK-27845][SQL][WIP] 
DataSourceV2: Insert into tables in multiple catalogs
URL: https://github.com/apache/spark/pull/24832#discussion_r292190578
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
 ##########
 @@ -118,6 +120,24 @@ case class DataSourceResolution(
         if newColumns.forall(_.name.size == 1) =>
       // only top-level adds are supported using AlterTableAddColumnsCommand
       AlterTableAddColumnsCommand(table, newColumns.map(convertToStructField))
+
+    case i @ 
InsertTableStatement(UnresolvedRelation(CatalogObjectIdentifier(Some(catalog), 
ident)),
+    _, query, overwrite, _) if query.resolved && !overwrite =>
 
 Review comment:
   Nit: indentation is off.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to