rdblue commented on a change in pull request #24832: [SPARK-27845][SQL][WIP]
DataSourceV2: Insert into tables in multiple catalogs
URL: https://github.com/apache/spark/pull/24832#discussion_r292188975
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -242,10 +242,20 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
ctx match {
case table: InsertIntoTableContext =>
val (tableIdent, partitionKeys, exists) = visitInsertIntoTable(table)
- InsertIntoTable(UnresolvedRelation(tableIdent), partitionKeys, query,
false, exists)
+ InsertTableStatement(
+ UnresolvedRelation(tableIdent),
+ partitionKeys,
+ query,
+ overwrite = false,
+ exists)
Review comment:
Can we rename this to `ifNotExists`? I think the other name isn't clear
enough and this is a good opportunity to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
