Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3783#discussion_r22698276
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -315,7 +314,7 @@ private[spark] class ExecutorAllocationManager(
private def onExecutorAdded(executorId: String): Unit = synchronized {
if (!executorIds.contains(executorId)) {
executorIds.add(executorId)
- executorIds.foreach(onExecutorIdle)
+ onExecutorIdle(executorId)
--- End diff --
> But its expireTime actually is already removed here, so if we don't mark
it idle when a new executor joins, it will never be removed.
But I have changed these codes to:
```
removeTimes.retain { case (executorId, expireTime) =>
now < expireTime || !removeExecutor(executorId)
}
```
It won't remove `(executorId, expireTime)` if `removeExecutor(executorId)`
return false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
