Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3783#discussion_r22632968
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -315,7 +314,7 @@ private[spark] class ExecutorAllocationManager(
       private def onExecutorAdded(executorId: String): Unit = synchronized {
         if (!executorIds.contains(executorId)) {
           executorIds.add(executorId)
    -      executorIds.foreach(onExecutorIdle)
    +      onExecutorIdle(executorId)
    --- End diff --
    
    If an idle executor (call this executor X) is not removed because the 
minimum is reached, it won't be removed. However, its expireTime isn't changed. 
So after new executor joins, `schedule()` will remove this idle executor since 
it's expired.
    
    Do you want to reset the `expireTime` of idle executors when a new Executor 
joins?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to