cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r296549087
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
##########
@@ -97,15 +97,16 @@ public void fetchBlocks(
String execId,
String[] blockIds,
BlockFetchingListener listener,
- DownloadFileManager downloadFileManager) {
+ DownloadFileManager downloadFileManager,
+ int shuffleGenerationId) {
Review comment:
nit: seems better to put `shuffleGenerationId` parameter right after `String
execId`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
