cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r296549177
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleClient.java
##########
@@ -41,14 +41,16 @@
* If it's not <code>null</code>, the remote blocks
will be streamed
* into temp shuffle files to reduce the memory
usage, otherwise,
* they will be kept in memory.
+ * @param shuffleGenerationId the shuffle generation id for all block ids to
fetch.
*/
public abstract void fetchBlocks(
String host,
int port,
String execId,
String[] blockIds,
BlockFetchingListener listener,
- DownloadFileManager downloadFileManager);
+ DownloadFileManager downloadFileManager,
+ int shuffleGenerationId);
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
