wangyum commented on a change in pull request #24985: [SPARK-28184][SQL][TEST]
Avoid creating new sessions in SparkMetadataOperationSuite
URL: https://github.com/apache/spark/pull/24985#discussion_r298239884
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala
##########
@@ -17,63 +17,21 @@
package org.apache.spark.sql.hive.thriftserver
-import java.util.{Arrays => JArrays, List => JList, Properties}
-
-import org.apache.hive.jdbc.{HiveConnection, HiveQueryResultSet}
-import org.apache.hive.service.auth.PlainSaslHelper
-import org.apache.thrift.protocol.TBinaryProtocol
-import org.apache.thrift.transport.TSocket
+import java.sql.ResultSet
class SparkMetadataOperationSuite extends HiveThriftJdbcTest {
override def mode: ServerMode.Value = ServerMode.binary
test("Spark's own GetSchemasOperation(SparkGetSchemasOperation)") {
- def testGetSchemasOperation(
Review comment:
Before this pr, we constrctor a HiveConnection, a TCLIService.Client, ...
and get `ResultSet` from:
```scala
rs = new HiveQueryResultSet.Builder(connection)
.setClient(client)
.setSessionHandle(sessHandle)
.setStmtHandle(client.GetSchemas(schemaReq).getOperationHandle)
.build()
```
After this pr, we get `ResultSet` from
`statement.getConnection.getMetaData.getSchemas`
cc @juliuszsompolski
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
