squito commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] :
Optimize Spark Scheduler to dequeue speculative tasks…
URL: https://github.com/apache/spark/pull/23677#discussion_r298356006
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -1029,12 +1062,11 @@ private[spark] class TaskSetManager(
for (tid <- runningTasksSet) {
val info = taskInfos(tid)
val index = info.index
- if (!successful(index) && copiesRunning(index) == 1 &&
info.timeRunning(time) > threshold &&
- !speculatableTasks.contains(index)) {
+ if (!successful(index) && copiesRunning(index) == 1 &&
info.timeRunning(time) > threshold) {
+ addPendingSpeculativeTask(index)
Review comment:
can you also add a test case that if you have multiple calls to
checkSpeculatbleTasks followed by multiple resources offers, you still only
submit one speculative task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
