squito commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] :
Optimize Spark Scheduler to dequeue speculative tasks…
URL: https://github.com/apache/spark/pull/23677#discussion_r299573161
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -246,85 +236,86 @@ private[spark] class TaskSetManager(
/** Add a task to all the pending-task lists that it should be on. */
private[spark] def addPendingTask(
index: Int,
- resolveRacks: Boolean = true): Unit = {
- for (loc <- tasks(index).preferredLocations) {
- loc match {
- case e: ExecutorCacheTaskLocation =>
- pendingTasksForExecutor.getOrElseUpdate(e.executorId, new
ArrayBuffer) += index
- case e: HDFSCacheTaskLocation =>
- val exe = sched.getExecutorsAliveOnHost(loc.host)
- exe match {
- case Some(set) =>
- for (e <- set) {
- pendingTasksForExecutor.getOrElseUpdate(e, new ArrayBuffer) +=
index
- }
- logInfo(s"Pending task $index has a cached location at ${e.host}
" +
- ", where there are executors " + set.mkString(","))
- case None => logDebug(s"Pending task $index has a cached location
at ${e.host} " +
- ", but there are no executors alive there.")
- }
- case _ =>
+ resolveRacks: Boolean = true,
+ speculative: Boolean = false): Unit = {
+ if (speculative) {
Review comment:
I think you could combine the code here even more
```scala
val pendingTaskSetToAddTo = if (speculative) pendingTasks else
pendingSpeculatableTasks
// ... mostly the original code from `addPendingTask` here, just adding
into pendingTaskSetToAddTo
```
the only differences seem to be speculative tasks didn't look at
`HDFSCacheTaskLocation`, which was a bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
