srowen commented on a change in pull request #24963: [SPARK-28159][ML] Make the
transform natively in ml framework to avoid extra conversion
URL: https://github.com/apache/spark/pull/24963#discussion_r298630743
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala
##########
@@ -609,26 +611,23 @@ private[clustering] object OnlineLDAOptimizer {
* statistics for updating lambda and `ids` - list of termCounts
vector indices.
*/
private[clustering] def variationalTopicInference(
- termCounts: Vector,
+ indices: List[Int],
Review comment:
Yes I think this kind of approach is what I had in mind, but keep code that
converts new .ml vectors to indices/values in the .ml package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
