srowen commented on a change in pull request #24963: [SPARK-28159][ML] Make the
transform natively in ml framework to avoid extra conversion
URL: https://github.com/apache/spark/pull/24963#discussion_r298629290
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala
##########
@@ -28,6 +28,7 @@ import org.apache.spark.SparkContext
import org.apache.spark.annotation.Since
import org.apache.spark.api.java.{JavaPairRDD, JavaRDD}
import org.apache.spark.graphx.{Edge, EdgeContext, Graph, VertexId}
+import org.apache.spark.ml.linalg.{Vector => NewVector, Vectors => NewVectors}
Review comment:
Ah OK, I think we don't want to import .ml vectors in .mllib here. But the
method below is only used in .ml now. Just move it to .ml.clustering.LDAModel
with your changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
