xuanyuanking commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r300173331
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleClient.java
##########
@@ -43,6 +44,18 @@
* they will be kept in memory.
*/
public abstract void fetchBlocks(
+ String host,
+ int port,
+ String execId,
+ int shuffleGenerationId,
+ String[] blockIds,
+ BlockFetchingListener listener,
+ DownloadFileManager downloadFileManager);
+
+ /**
+ * Fetch a sequence of non-shuffle blocks from a remote node asynchronously.
+ */
+ public abstract void fetchDataBlocks(
Review comment:
@cloud-fan During I do the refactor of splitting ShuffleFetcher and
NonShuffleFetcher and fix the UT, I realize that after SPARK-27677, the
ExternalShuffleClient not only handle shuffle block but also handle local disk
persist block, in the latest commit I just split them into 2 functions, but
it's maybe strange to handle non-shuffle block in a `ShuffleClient`, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
