xuanyuanking commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r299787736
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -2751,17 +2746,141 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
assert(failedStages.collect {
case stage: ResultStage => stage
}.head.findMissingPartitions() == Seq(0, 1))
-
scheduler.resubmitFailedStages()
+ (shuffleId1, shuffleId2)
+ }
+
+ test("SPARK-25341: abort stage while using old fetch protocol") {
+ // reset the test context with using old fetch protocol
+ afterEach()
+ val conf = new SparkConf()
+ conf.set(config.SHUFFLE_USE_OLD_FETCH_PROTOCOL.key, "true")
+ init(conf)
+
+ val (shuffleId1, _) = constructIndeterminateStageRetryScenario()
+ // The second task of the `shuffleMapRdd2` failed with fetch failure
Review comment:
Great thanks for the careful review, change to fail the first task in
7259500.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
