HeartSaVioR commented on a change in pull request #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25048#discussion_r300519565
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala ########## @@ -36,6 +38,9 @@ class RateStreamContinuousStream(rowsPerSecond: Long, numPartitions: Int) extend val perPartitionRate = rowsPerSecond.toDouble / numPartitions.toDouble + val highestCommittedValue = new AtomicLong(Long.MinValue) + val firstCommittedTime = new AtomicLong(Long.MinValue) Review comment: Actually yes, and `creationTime` is also only used from tests. Rate stream is designed for test and evaluation purpose, so it seems OK to modify rate stream to support tests. Btw, I'll adjust the scope to `private[sql]`, as it doesn't need to be exposed outside of Spark. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
