Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3997#discussion_r22800634
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -449,6 +449,16 @@ class SparseVector(
override def toString: String =
"(%s,%s,%s)".format(size, indices.mkString("[", ",", "]"),
values.mkString("[", ",", "]"))
--- End diff --
Yeah I was thinking of performance too. That is a fair point of course
about not changing the semantics. I think the `hashCode` impl could be changed
in both places to produce the same result while being faster for sparse
vectors: what if the hash were defined only over nonzero entries? I think
`equals` could likewise be sped up also for the case of comparing sparse to
dense? that is I think this can be taken a step further than just optimizing
sparse == sparse.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
