Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3997#discussion_r22893260
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -449,6 +449,16 @@ class SparseVector(
override def toString: String =
"(%s,%s,%s)".format(size, indices.mkString("[", ",", "]"),
values.mkString("[", ",", "]"))
+ override def equals(other: Any): Boolean = {
+ other match {
+ case v: SparseVector =>
+ this.size == v.size &&
+ util.Arrays.equals(this.indices, v.indices) &&
+ util.Arrays.equals(this.values, v.values)
--- End diff --
Just realized that this did change the behavior of the original `equals`,
because we allow `values` to have explicit zeros. Maybe we can use
`Vectors.sqdist(this, other) == 0` to implement `equals()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
