srowen commented on a change in pull request #24996: [SPARK-28199][SS] Replace
deprecated ProcessingTime with ProcessingTimeTrigger and make invisible to end
users
URL: https://github.com/apache/spark/pull/24996#discussion_r300909196
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
##########
@@ -27,3 +32,34 @@ import org.apache.spark.sql.streaming.Trigger
@Experimental
@Evolving
case object OneTimeTrigger extends Trigger
+
+/**
+ * A [[Trigger]] that runs a query periodically based on the processing time.
If `interval` is 0,
+ * the query will run as fast as possible.
+ */
+@Evolving
+private[sql] case class ProcessingTimeTrigger(intervalMs: Long) extends
Trigger {
Review comment:
@dongjoon-hyun I don't particularly care where the implementations live, I'm
just looking for consistency. It's not terribly consistent to begin with. I
think putting the private implementations in `Triggers.scala` is a step in the
right direction, given that this file exists at all. I think this change is OK
as-is. I don't think we have to move other implementations, though, anything
that improves consistency is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
