srowen commented on a change in pull request #24996: [SPARK-28199][SS] Replace
deprecated ProcessingTime with ProcessingTimeTrigger and make invisible to end
users
URL: https://github.com/apache/spark/pull/24996#discussion_r301633568
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
##########
@@ -27,3 +32,34 @@ import org.apache.spark.sql.streaming.Trigger
@Experimental
@Evolving
case object OneTimeTrigger extends Trigger
+
+/**
+ * A [[Trigger]] that runs a query periodically based on the processing time.
If `interval` is 0,
+ * the query will run as fast as possible.
+ */
+@Evolving
+private[sql] case class ProcessingTimeTrigger(intervalMs: Long) extends
Trigger {
Review comment:
My suggestion is we follow the comment above by moving `OneTimeTrigger` too,
and leave it there. That's more consistent, and consistent with the intent.
This leaves the class potentially 'public' in the bytecode, but it was before,
and that's true of lots of `private[spark]` classes anyway. While I wouldn't
argue with further moving things to `sql/execution`, I think that just putting
the implementations in their natural home right now sounds coherent and an
improvement, and doesn't expand the change much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
