dongjoon-hyun commented on a change in pull request #25072: [SPARK-28294][CORE]
Support `spark.history.fs.cleaner.maxNum` configuration
URL: https://github.com/apache/spark/pull/25072#discussion_r301241408
##########
File path: core/src/main/scala/org/apache/spark/internal/config/History.scala
##########
@@ -49,6 +49,13 @@ private[spark] object History {
.timeConf(TimeUnit.SECONDS)
.createWithDefaultString("7d")
+ // This is designed to be smaller than the default value of
+ // `dfs.namenode.fs-limits.max-directory-items` (1024 * 1024).
+ val MAX_LOG_NUM = ConfigBuilder("spark.history.fs.cleaner.maxNum")
Review comment:
- Sure for the document.
- The value is designed to be smaller as described at line 52 (`This is
designed to be smaller than the default value`) because Spark applications will
fail due to event log file creation if the directory contains 1024*1024 files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
