dongjoon-hyun commented on a change in pull request #25072: [SPARK-28294][CORE]
Support `spark.history.fs.cleaner.maxNum` configuration
URL: https://github.com/apache/spark/pull/25072#discussion_r301240203
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1066,19 +1103,21 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
throw new NoSuchElementException(s"Cannot find attempt $attemptId of
$appId."))
}
- private def deleteLog(fs: FileSystem, log: Path): Unit = {
+ private def deleteLog(fs: FileSystem, log: Path): Boolean = {
+ var deleted = false
Review comment:
~We need this because `fs.delete(log, true)` doesn't succeed sometimes.~
This will be smaller because `catch` also needs `false` after two `logInfo`s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
