dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL]
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302307831
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -534,7 +534,8 @@ private[hive] class TestHiveSparkSession(
}
// Clean out the Hive warehouse between each suite
- val warehouseDir = new File(new
URI(sparkContext.conf.get("spark.sql.warehouse.dir")).getPath)
+ val warehouseDir = new File(new URI(
+ sparkContext.conf.get(StaticSQLConf.WAREHOUSE_PATH.key)).getPath)
Review comment:
```
- val warehouseDir = new File(new URI(
- sparkContext.conf.get(StaticSQLConf.WAREHOUSE_PATH.key)).getPath)
+ val warehouseDir = new File(new
URI(sparkContext.conf.get(WAREHOUSE_PATH.key)).getPath)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
