dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL]
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302704994
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
##########
@@ -477,8 +478,8 @@ class SQLWindowFunctionSuite extends QueryTest with
SharedSQLContext {
|WINDOW w1 AS (ORDER BY x ROWS BETWEEN UNBOUNDED PRECEDiNG AND CURRENT
RoW)
""".stripMargin)
- withSQLConf("spark.sql.windowExec.buffer.in.memory.threshold" -> "1",
- "spark.sql.windowExec.buffer.spill.threshold" -> "2") {
+ withSQLConf(SQLConf.WINDOW_EXEC_BUFFER_IN_MEMORY_THRESHOLD.key -> "1",
+ SQLConf.WINDOW_EXEC_BUFFER_SPILL_THRESHOLD.key -> "2") {
Review comment:
```
- withSQLConf(SQLConf.WINDOW_EXEC_BUFFER_IN_MEMORY_THRESHOLD.key -> "1",
- SQLConf.WINDOW_EXEC_BUFFER_SPILL_THRESHOLD.key -> "2") {
+ withSQLConf(WINDOW_EXEC_BUFFER_IN_MEMORY_THRESHOLD.key -> "1",
+ WINDOW_EXEC_BUFFER_SPILL_THRESHOLD.key -> "2") {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
