mgaido91 commented on a change in pull request #25041: [SPARK-28133][SQL] Add
acosh/asinh/atanh functions to SQL
URL: https://github.com/apache/spark/pull/25041#discussion_r302846864
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -199,6 +199,12 @@ class MathExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkConsistencyBetweenInterpretedAndCodegen(Sinh, DoubleType)
}
+ test("asinh") {
+ testUnary(Asinh, (x: Double) => math.log(x + math.sqrt(x * x + 1.0)))
+ checkConsistencyBetweenInterpretedAndCodegen(Asinh, DoubleType)
+ checkEvaluation(Asinh(Double.NegativeInfinity), Double.NegativeInfinity)
Review comment:
can you also add test cases passing `null` as input?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
