mgaido91 commented on a change in pull request #25041: [SPARK-28133][SQL] Add
acosh/asinh/atanh functions to SQL
URL: https://github.com/apache/spark/pull/25041#discussion_r303230469
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -557,6 +580,31 @@ case class Sin(child: Expression) extends
UnaryMathExpression(math.sin, "SIN")
""")
case class Sinh(child: Expression) extends UnaryMathExpression(math.sinh,
"SINH")
+@ExpressionDescription(
+ usage = """
+ _FUNC_(expr) - Returns inverse hyperbolic sine of `expr`.
+ """,
+ arguments = """
+ Arguments:
+ * expr - hyperbolic angle
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_(0);
+ 0.0
+ """,
+ since = "3.0.0")
+case class Asinh(child: Expression)
+ extends UnaryMathExpression((x: Double) => x match {
+ case Double.NegativeInfinity => Double.NegativeInfinity
+ case _ => math.log(x + math.sqrt(x * x + 1.0)) }, "ASINH") {
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ defineCodeGen(ctx, ev, c =>
Review comment:
as I mentioned earlier, I would prefer rewriting this as an `if`. There may
be stage cases where `$c` contains a cast or something similar which may cause
issues (I has similar problem in another PR, Janino is not perfect with this
syntax in the version we're using). So it think it would be safer to rewrite as
an `if`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
