dongjoon-hyun commented on issue #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#issuecomment-511218315 @Tonix517 and @mgaido91 . To sum up, the last thing we need to check was https://github.com/janino-compiler/janino/issues/90 which is reported by Apache Spark community at https://github.com/apache/spark/pull/24636. In the old PR https://github.com/apache/spark/pull/24636, we also used `cond ? true : false` expression. > s"Object $argTerm = ${eval.isNull} ? null : $convertersTerm[$i].apply(${eval.value});" It seems that we are not in that case, but let me check that again today.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
