dongjoon-hyun commented on issue #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#issuecomment-511219580 For the second case, `a cast added to the terms`, > The bug opened there for janino cannot happen here, but I remember I also had issues in that PR in a case when there was a cast added to the terms. I tested some, but like line 37, it's declared already `double project_value_1 = -1.0;` before reaching this math function. ``` /* 037 */ double project_value_1 = -1.0; /* 038 */ if (!project_isNull_2) { /* 039 */ try { /* 040 */ project_value_1 = Double.valueOf(project_value_2.toString()); /* 041 */ } catch (java.lang.NumberFormatException e) { /* 042 */ project_isNull_1 = true; /* 043 */ } /* 044 */ } /* 045 */ boolean project_isNull_0 = project_isNull_1; /* 046 */ double project_value_0 = -1.0; /* 047 */ /* 048 */ if (!project_isNull_1) { /* 049 */ project_value_0 = project_value_1 == Double.NEGATIVE_INFINITY ? Double.NEGATIVE_INFINITY : java.lang.Math.log(project_value_1 + java.lang.Math.sqrt(project_value_1 * project_value_1 + 1.0)); /* 050 */ } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
