holdenk commented on a change in pull request #20658: [SPARK-23488][python] Add
missing catalog methods to python API
URL: https://github.com/apache/spark/pull/20658#discussion_r304011185
##########
File path: python/pyspark/sql/catalog.py
##########
@@ -138,6 +139,78 @@ def listColumns(self, tableName, dbName=None):
isBucket=jcolumn.isBucket()))
return columns
+ @ignore_unicode_prefix
+ @since(3.0)
+ def databaseExists(self, dbName):
+ """Check if the database with the specified name exists."""
+ return self._jcatalog.databaseExists(dbName)
+
+ @ignore_unicode_prefix
+ @since(3.0)
+ def functionExists(self, functionName, dbName=None):
+ """Check if the function with the specified name exists.
+
+ If no database is specified, the current database is used.
+ """
+ if dbName is None:
+ dbName = self.currentDatabase()
+ return self._jcatalog.functionExists(dbName, functionName)
+
+ @ignore_unicode_prefix
+ @since(3.0)
+ def tableExists(self, tableName, dbName=None):
Review comment:
Same comment, I don't think matching the Scala API is necessarily the right
thing to do here. I think this more closely matches Python developers
expectations of positional arguments behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]