holdenk commented on a change in pull request #20658: [SPARK-23488][python] Add
missing catalog methods to python API
URL: https://github.com/apache/spark/pull/20658#discussion_r304010743
##########
File path: python/pyspark/sql/catalog.py
##########
@@ -138,6 +139,78 @@ def listColumns(self, tableName, dbName=None):
isBucket=jcolumn.isBucket()))
return columns
+ @ignore_unicode_prefix
+ @since(3.0)
+ def databaseExists(self, dbName):
+ """Check if the database with the specified name exists."""
+ return self._jcatalog.databaseExists(dbName)
+
+ @ignore_unicode_prefix
+ @since(3.0)
+ def functionExists(self, functionName, dbName=None):
Review comment:
I think as written is more Python-standard API. Certainly we can do
interesting things with vargs/kwargs to make this look more like Scala, but I
don't think that would be ideal here. One possibility could be requiring only
kwargs (named arguments) so it's not ambigious. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
