Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3833#discussion_r22931938
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -61,20 +67,70 @@ class LogisticRegressionModel (
override protected def predictPoint(dataMatrix: Vector, weightMatrix:
Vector,
--- End diff --
I know this was in the existing code, but `dataMatrix` isn't conceptually a
matrix. `weightMatrix` now is, but it's represented as a `Vector`. There is a
`Matrix` class that's more suitable, it seems. I know, changing that would
change the API. There could be a second method accepting `Vector` and `Matrix`
though. The existing one is for binary, new one for multinomial, and the former
can call the latter, even.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
