Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3833#discussion_r22967246
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -61,20 +67,70 @@ class LogisticRegressionModel (
override protected def predictPoint(dataMatrix: Vector, weightMatrix:
Vector,
--- End diff --
The argument to the gradient calculation is properly a vector of weights,
so that need not change for API reasons. So is it just having to do the
translation? it's a line of code I think, although requires a copy. Maybe
someone else can weigh in with an opinion too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
