Ngone51 commented on a change in pull request #25047: [WIP][SPARK-27371][CORE]
Support GPU-aware resources scheduling in Standalone
URL: https://github.com/apache/spark/pull/25047#discussion_r304920426
##########
File path: core/src/test/scala/org/apache/spark/SparkContextSuite.scala
##########
@@ -839,26 +839,27 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
assume(!(Utils.isWindows))
withTempDir { dir =>
val discoveryScript = createTempScriptWithExpectedOutput(dir,
"resourceDiscoveryScript",
- """{"name": "gpu","addresses":["0", "1", "2"]}""")
+ """{"name": "gpu","addresses":["0", "1", "2", "3", "4", "5", "6", "7",
"8"]}""")
Review comment:
Previously, this discoveryScript was used for those 3 executors directly.
And now, when we get resources scheduling in Standalone, this discoveryScript
should be used by Worker, otherwise executor can't be launched due to no
confined resources for worker. As a result, we need to prepare 9 isolated
resource addresses for 3 workers in the same host in order to launch 3
executor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
