Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3916#issuecomment-70006438
> Did you consider using ProcessBuilder for building the commands in
AbstractLauncher?
`ProcessBuilder` doesn't help here at all. The platform-specific branches
aren't related to how to run a process, but how to return a string that can be
executed from a bash script on Linux/Mac or batch script on Windows.
The code that launches processes directly (`SparkLauncher.launch()`) uses
ProcessBuilder and doesn't have any platform-specific code.
> If we want Spark to start exposing constants for these, we should do it
somewhere in core
This library cannot depend on core.
> I'm worried that people are going to start referring to these constants
That's probably a good thing. It's a centralized place where they're
defined, and thus it means that people will have to think before changing them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
