zsxwing commented on a change in pull request #22282: [SPARK-23539][SS] Add
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r306008877
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaUtilsSuite.scala
##########
@@ -61,4 +63,24 @@ class UnsafeMapSuite extends SparkFunSuite {
assert(mapDataSer.valueArray().getInt(0) == 19286)
assert(mapDataSer.getBaseObject.asInstanceOf[Array[Byte]].length == 1024)
}
+
+ test("UnsafeMap from Kafka Headers") {
Review comment:
Could you move `UnsafeMapSuite.scala` back? We should create a new test
suite for `KafkaUtils.toUnsafeMapData`. The other tests should stay in
`catalyst`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
