zsxwing commented on a change in pull request #22282: [SPARK-23539][SS] Add
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r306014865
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRecordToUnsafeRowConverter.scala
##########
@@ -25,8 +25,12 @@ import org.apache.spark.sql.catalyst.util.DateTimeUtils
import org.apache.spark.unsafe.types.UTF8String
/** A simple class for converting Kafka ConsumerRecord to UnsafeRow */
-private[kafka010] class KafkaRecordToUnsafeRowConverter {
- private val rowWriter = new UnsafeRowWriter(7)
+private[kafka010] class KafkaRecordToUnsafeRowConverter(includeHeaders:
Boolean) {
+ private val rowWriter = if (includeHeaders) {
Review comment:
nit: Use `new
UnsafeRowWriter(KafkaOffsetReader.kafkaSchema(includeHeaders).size)` to avoid
magic numbers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
