Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23060808
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -257,8 +257,8 @@ private[spark] class Executor(
val serviceTime = System.currentTimeMillis() - taskStart
val metrics = attemptedTask.flatMap(t => t.metrics)
for (m <- metrics) {
- m.executorRunTime = serviceTime
- m.jvmGCTime = gcTime - startGCTime
+ m.incExecutorRunTime(serviceTime)
--- End diff --
The purpose of this original patch was to just lock down the visibility, so
I think it's fine to have -package-private setters in cases where we don't
simply increment/decrement. We could also just only have setters (and not
inc/dec). Basically as long as they are private, I don't mind. Maybe there is
some value to restricting certain ones to inc/dec to provide more safety.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
