Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4020#discussion_r23130489
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala 
---
    @@ -44,42 +44,62 @@ class TaskMetrics extends Serializable {
       /**
        * Host's name the task runs on
        */
    -  var hostname: String = _
    -
    +  private var _hostname: String = _
    +  def hostname = _hostname
    +  private[spark] def setHostname(value : String) = _hostname = value
    --- End diff --
    
    `Should be "value: String"` with no space (not sure why our style checks 
didn't catch this).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to