cloud-fan commented on a change in pull request #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test URL: https://github.com/apache/spark/pull/25243#discussion_r307237560
########## File path: sql/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSessionWithFreshCopy.scala ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.test + +import org.scalatest.Suite + +// A variant of SharedSparkSession. It creates a fresh copy of the spark session before each test. +trait SharedSparkSessionWithFreshCopy extends SharedSparkSession { self: Suite => Review comment: We have `SQLTestData`, which creates DataFrames and the DataFrames are shared between all the tests in one suite. A DataFrame is associated with one `SparkSession` instance, but we create a new `SparkSession` instance for each test. If we change the config in one test, the DataFrames won't get affected. That said, to apply `SharedSparkSessionWithFreshCopy`, the test suite should create DataFrames in each test. So we need to apply it incrementally. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
