cloud-fan commented on a change in pull request #25243:
[SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before
each test
URL: https://github.com/apache/spark/pull/25243#discussion_r307239834
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/test/TestSQLContext.scala
##########
@@ -47,6 +51,10 @@ private[spark] class TestSparkSession(sc: SparkContext)
extends SparkSession(sc)
testData.loadTestData()
}
+ override def newSession(): TestSparkSession = {
+ new TestSparkSession(sparkContext, Some(sharedState))
+ }
+
private object testData extends SQLTestData {
Review comment:
There are only 3 java test suites that rely on it, and I don't think we
would apply `SharedSparkSessionWithFreshCopy` for them. They don't even extend
`SharedSparkSession`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
