wangyum commented on a change in pull request #25252: [SPARK-28510][SQL]
Implement Spark's own GetFunctionsOperation
URL: https://github.com/apache/spark/pull/25252#discussion_r309137289
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala
##########
@@ -182,4 +182,31 @@ class SparkMetadataOperationSuite extends
HiveThriftJdbcTest {
checkResult(metaData.getTableTypes, Seq("TABLE", "VIEW"))
}
}
+
Review comment:
I have added some tests:
```scala
ssert(rs.getString("REMARKS").startsWith(s"${functionName(i)}("))
assert(rs.getString("SPECIFIC_NAME").startsWith("org.apache.spark.sql.catalyst"))
```
Do you think we need to assert more details?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
