wangyum commented on a change in pull request #25252: [SPARK-28510][SQL]
Implement Spark's own GetFunctionsOperation
URL: https://github.com/apache/spark/pull/25252#discussion_r309612419
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala
##########
@@ -182,4 +182,45 @@ class SparkMetadataOperationSuite extends
HiveThriftJdbcTest {
checkResult(metaData.getTableTypes, Seq("TABLE", "VIEW"))
}
}
+
+ test("Spark's own GetFunctionsOperation(SparkGetFunctionsOperation)") {
+ def checkResult(rs: ResultSet, functionName: Seq[String]): Unit = {
+ for (i <- functionName.indices) {
+ assert(rs.next())
+ assert(rs.getString("FUNCTION_SCHEM") === "default")
+ assert(rs.getString("FUNCTION_NAME") === functionName(i))
+ assert(rs.getString("REMARKS").startsWith(s"${functionName(i)}("))
+ assert(rs.getInt("FUNCTION_TYPE") ===
DatabaseMetaData.functionResultUnknown)
+
assert(rs.getString("SPECIFIC_NAME").startsWith("org.apache.spark.sql.catalyst"))
+ }
+ // Make sure there are no more elements
+ assert(!rs.next())
+ }
+
+ withJdbcStatement() { statement =>
+ val metaData = statement.getConnection.getMetaData
+ // Hive does not have an overlay function, we use overlay to test.
+ checkResult(metaData.getFunctions(null, null, "overlay"), Seq("overlay"))
+ checkResult(metaData.getFunctions(null, null, "overla*"), Seq("overlay"))
+ checkResult(metaData.getFunctions(null, "", "overla*"), Seq("overlay"))
+ checkResult(metaData.getFunctions(null, null, "does-not-exist*"),
Seq.empty)
+ checkResult(metaData.getFunctions(null, "default", "overlay"),
Seq("overlay"))
+ checkResult(metaData.getFunctions(null, "default", "shift*"),
+ Seq("shiftleft", "shiftright", "shiftrightunsigned"))
+ }
+
+ withJdbcStatement() { statement =>
+ val metaData = statement.getConnection.getMetaData
+ val rs = metaData.getFunctions(null, "default", "upPer")
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
