rdblue commented on a change in pull request #25348: [RFC][SPARK-28554][SQL]
Adds a v1 fallback writer implementation for v2 data source codepaths
URL: https://github.com/apache/spark/pull/25348#discussion_r310750878
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -129,7 +137,8 @@ case class AtomicCreateTableAsSelectExec(
}
val stagedTable = catalog.stageCreate(
ident, query.schema, partitioning.toArray, properties.asJava)
- writeToStagedTable(stagedTable, writeOptions, ident)
+ val mode = if (ifNotExists) SaveMode.Ignore else SaveMode.ErrorIfExists
Review comment:
Same problem here. I think mode should always be Append because that's the
only one with reliable behavior that matches v2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
