rdblue commented on a change in pull request #25348: [RFC][SPARK-28554][SQL]
Adds a v1 fallback writer implementation for v2 data source codepaths
URL: https://github.com/apache/spark/pull/25348#discussion_r311654965
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -200,14 +201,15 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
catalog,
ident,
parts,
+ query,
planLater(query),
props,
writeOptions,
orCreate = orCreate) :: Nil
}
case AppendData(r: DataSourceV2Relation, query, _) =>
- AppendDataExec(r.table.asWritable, r.options, planLater(query)) :: Nil
+ AppendDataExec(r.table.asWritable, r.options, query, planLater(query))
:: Nil
Review comment:
We talked about this separately and I think this is okay for now. In the
future, we can add a separate `Write` produced by the builder (like `Scan` in
the read side) and use that to use a separate plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
