shahidki31 commented on a change in pull request #25369: [SPARK-28638][WebUI]
Task summary metrics are wrong when there are running tasks
URL: https://github.com/apache/spark/pull/25369#discussion_r311719400
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -156,7 +162,8 @@ private[spark] class AppStatusStore(
// cheaper for disk stores (avoids deserialization).
val count = {
Utils.tryWithResource(
- if (store.isInstanceOf[InMemoryStore]) {
+ if (isInMemoryStore) {
Review comment:
@gengliangwang If I understand correctly, #23088 is actually fixing this
issue. right ?(At least history server case).
Because, `count` is always filtering out the running tasks, as
`ExecutorRunTime` will be defined for only finished tasks. But `scan tasks`
contains all the tasks, including running tasks.
https://github.com/apache/spark/blob/a59fdc4b5783be591a236bfc60d1107caa818412/core/src/main/scala/org/apache/spark/status/AppStatusStore.scala#L169
https://github.com/apache/spark/blob/a59fdc4b5783be591a236bfc60d1107caa818412/core/src/main/scala/org/apache/spark/status/AppStatusStore.scala#L263-L265
So, reverting 23088 and hence this PR, would not fix the issue? Please
correct me if I am wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
