dongjoon-hyun commented on a change in pull request #25410: [SPARK-28690][SQL]
Add the `date_part` function for timestamps and dates
URL: https://github.com/apache/spark/pull/25410#discussion_r312770020
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1876,3 +1876,38 @@ case class Decade(child: Expression) extends
UnaryExpression with ImplicitCastIn
defineCodeGen(ctx, ev, c => s"$dtu.getDecade($c)")
}
}
+
+case class DatePart(field: Expression, source: Expression, child: Expression)
Review comment:
As you see the UT failure, I enforced the function description by UT,
@MaxGekk . You shall not pass. :grin:
Please add a proper description annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
