dongjoon-hyun commented on a change in pull request #25410: [SPARK-28690][SQL]
Add the `date_part` function for timestamps and dates
URL: https://github.com/apache/spark/pull/25410#discussion_r312856728
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1876,3 +1876,38 @@ case class Decade(child: Expression) extends
UnaryExpression with ImplicitCastIn
defineCodeGen(ctx, ev, c => s"$dtu.getDecade($c)")
}
}
+
+case class DatePart(field: Expression, source: Expression, child: Expression)
Review comment:
@MaxGekk .
- First of all, where did you get that idea about that CLI command? The
failed test case in Jekins is
[SQLQuerySuite.SPARK-14415](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108938/testReport/org.apache.spark.sql/SQLQuerySuite/SPARK_14415__All_functions_should_have_own_descriptions/),
not `SQLQueryTestSuite`.
- Second, what I recommended was the SQL **module** test is `build/sbt
"project sql" test`.
Since you are one of the active SQL-area contributors in Apache Spark
community, let me recommend you once more to run **the module test** at least
before making a PR.
- If you touch `catalyst` module, you should run `build/sbt "project
catalyst" test` at least.
- if you touch `sql` module, you should run `build/sbt "project sql" test`
at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
