dongjoon-hyun commented on a change in pull request #25408: [SPARK-28687][SQL]
Support `epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()`
URL: https://github.com/apache/spark/pull/25408#discussion_r312775959
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -455,6 +456,22 @@ object DateTimeUtils {
(MICROSECONDS.toSeconds(localTimestamp(microsec, timeZone)) % 60).toInt
}
+ /**
+ * Returns seconds, including fractional parts, multiplied by 1 000. The
timestamp
Review comment:
Let me ask you in this way, @MaxGekk .
1. If you think this is better, why not Java style `1_000_000` ? (AFAIK,
this is supported since JDK7).
2. And, does Apache Spark have `1 000 000` or `1 000` in our code?
3. In this PR, I don't find any explanation why you introduce this new style
in Apache Spark community in this PR.
4. Finally, this is Apache Spark doc, not `PostgreSQL` doc. A blind
`copy&paste` is unable to justify that you thought this is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
